Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Gateway] Support access key authentication #5509

Merged
merged 6 commits into from
May 6, 2024

Conversation

TomerShor
Copy link
Member

Add support for access key authentication mode, that uses the Cookie header with Iguazio access key for authentication.

Implements https://iguazio.atlassian.net/browse/ML-6359

@TomerShor TomerShor requested a review from alonmr May 5, 2024 11:38
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condition that on minimum iguazio version (where you have the fix to support control planes

@TomerShor TomerShor requested a review from liranbg May 5, 2024 13:24
@TomerShor TomerShor changed the title [API Gateways] Support access key authentication [API Gateway] Support access key authentication May 5, 2024
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small comments

mlrun/platforms/iguazio.py Outdated Show resolved Hide resolved
mlrun/runtimes/nuclio/api_gateway.py Outdated Show resolved Hide resolved
mlrun/platforms/iguazio.py Outdated Show resolved Hide resolved
tests/platforms/test_iguazio.py Outdated Show resolved Hide resolved
@TomerShor TomerShor requested a review from alonmr May 6, 2024 08:07
@TomerShor TomerShor merged commit 8724488 into mlrun:development May 6, 2024
10 checks passed
@TomerShor TomerShor deleted the task/ML-6359 branch May 6, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants