[FeatureStore] Spark read optimization #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CSVTarget and DFTarget
…CSVSource, dataframeSource and BigQuerySource
only in parquetsource or parquettarget.
gtopper
requested changes
May 19, 2024
mlrun/datastore/sources.py
Outdated
| none_exists = False | ||
| value = list(value) | ||
| for none_value in none_values: | ||
| if none_value in value: |
There was a problem hiding this comment.
This issue is still outstanding.
| kind = None if self.run_local else "remote-spark" | ||
| resp = fstore.get_offline_features( | ||
| feature_vector=vec, | ||
| additional_filters=[("bad", "=", 95)], |
There was a problem hiding this comment.
Still missing a NaN value in the test data afaict. Not to be confused with None.
gtopper
reviewed
May 20, 2024
gtopper
reviewed
May 20, 2024
Co-authored-by: Gal Topper <gal.topper@gmail.com>
…ark_read_optimisation
gtopper
reviewed
May 21, 2024
Co-authored-by: Gal Topper <gal.topper@gmail.com>
Co-authored-by: Gal Topper <gal.topper@gmail.com>
gtopper
reviewed
May 21, 2024
gtopper
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a)spark_merger
b) ParquetSource.to_spark_df.
ML-6289