Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrontendSpec] Add internal_labels to frontend_spec #5542

Merged
merged 32 commits into from
May 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
87729c0
Add internal_labels to frontend_spec
roei3000b May 9, 2024
23b631f
Merge branch 'development' into ML-5939-new
roei3000b May 16, 2024
3aeed06
Merge branch 'development' into ML-5939-new
roei3000b May 20, 2024
460272a
Fix cr
roei3000b May 21, 2024
ab2912f
Fix format
roei3000b May 21, 2024
4da613a
Merge branch 'development' into ML-5939-new
roei3000b May 21, 2024
2e4050e
Create MlrunInternalLabels class
roei3000b May 22, 2024
4706f40
Merge branch 'development' of github.com:mlrun/mlrun into ML-5939-new
roei3000b May 22, 2024
1f849d5
Merge remote-tracking branch 'origin/ML-5939-new' into ML-5939-new
roei3000b May 22, 2024
ac19abf
Merge branch 'development' into ML-5939-new
roei3000b May 22, 2024
361f590
Fix imports
roei3000b May 22, 2024
2011e99
Fix cr
roei3000b May 22, 2024
7b591ca
Fix linter
roei3000b May 22, 2024
38d7f2c
Merge branch 'development' into ML-5939-new
roei3000b May 22, 2024
8dfe91d
Merge branch 'development' into ML-5939-new
roei3000b May 23, 2024
3f0cdae
Fix cr
roei3000b May 23, 2024
f7b1e2f
Fix tests
roei3000b May 23, 2024
9d89680
Fix CR
roei3000b May 23, 2024
cf52abe
bump mlrun-pipelines-kfp-common-experiment
roei3000b May 23, 2024
ffeb70c
Fix imports
roei3000b May 23, 2024
dd53b0c
Merge branch 'development' into ML-5939-new
roei3000b May 23, 2024
3544b71
Fix cr
roei3000b May 26, 2024
0c1ca65
Merge remote-tracking branch 'origin/ML-5939-new' into ML-5939-new
roei3000b May 26, 2024
9cb16c1
Merge branch 'development' into ML-5939-new
roei3000b May 26, 2024
c94938d
Merge branch 'development' into ML-5939-new
roei3000b May 26, 2024
0983238
Fix imports
roei3000b May 26, 2024
b179cf1
Merge remote-tracking branch 'origin/ML-5939-new' into ML-5939-new
roei3000b May 26, 2024
a2e11f7
Fix tests
roei3000b May 26, 2024
18411d1
Merge branch 'development' into ML-5939-new
roei3000b May 26, 2024
c4ee26a
Fix ci
roei3000b May 26, 2024
c26a728
Merge remote-tracking branch 'origin/ML-5939-new' into ML-5939-new
roei3000b May 26, 2024
e7b3778
Merge branch 'development' into ML-5939-new
roei3000b May 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mlrun/common/schemas/frontend_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,4 @@ class FrontendSpec(pydantic.BaseModel):
feature_store_data_prefixes: typing.Optional[dict[str, str]]
allowed_artifact_path_prefixes_list: list[str]
ce: typing.Optional[dict]
internal_labels: list[str] = []
4 changes: 4 additions & 0 deletions mlrun/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,10 @@ def resolve_chief_api_url(self) -> str:
self.httpdb.clusterization.chief.url = chief_api_url
return self.httpdb.clusterization.chief.url

@staticmethod
def internal_labels():
return ["kind", "host"]

roei3000b marked this conversation as resolved.
Show resolved Hide resolved
@staticmethod
def get_storage_auto_mount_params():
auto_mount_params = {}
Expand Down
1 change: 1 addition & 0 deletions server/api/api/endpoints/frontend_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def get_frontend_spec(
feature_store_data_prefixes=config.feature_store.data_prefixes.to_dict(),
allowed_artifact_path_prefixes_list=get_allowed_path_prefixes_list(),
ce=config.ce.to_dict(),
internal_labels=config.internal_labels(),
)


Expand Down
2 changes: 2 additions & 0 deletions tests/api/api/test_frontend_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ def test_get_frontend_spec(
== server.api.utils.builder.resolve_mlrun_install_command_version()
)

assert frontend_spec.internal_labels == mlrun.mlconf.internal_labels()


def test_get_frontend_spec_jobs_dashboard_url_resolution(
db: sqlalchemy.orm.Session, client: fastapi.testclient.TestClient
Expand Down
Loading