[API] Support multiple state filter on runs api #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
May 16, 2024
alonmr
reviewed
May 16, 2024
There was a problem hiding this comment.
Do we want to keep the state param forever? why not deprecate it?
To deprecate you need 2 things:
- Deprecate it from HTTPRunDB
- Deprecate the query param - see https://fastapi.tiangolo.com/reference/parameters/#fastapi.Query
@roei3000b - this should be a followup pr |
rokatyy
pushed a commit
to rokatyy/mlrun
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before vs pr we can filter runs by only one specific state.
In this pr we introduce option to filter by multiple states.
https://iguazio.atlassian.net/browse/ML-6450