Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model Monitoring] Add invocations metric #5581

Merged
merged 27 commits into from
May 22, 2024
Merged

[Model Monitoring] Add invocations metric #5581

merged 27 commits into from
May 22, 2024

Conversation

gtopper
Copy link
Collaborator

@gtopper gtopper commented May 16, 2024 •
edited by jira bot
Loading

@gtopper gtopper requested a review from Eyal-Danieli May 16, 2024 08:56
@gtopper gtopper marked this pull request as draft May 16, 2024 08:56
@gtopper gtopper changed the title [Model Monitoring] Add invocation rate to metrics [Model Monitoring] Add invocations metric May 16, 2024
@gtopper gtopper marked this pull request as ready for review May 19, 2024 04:25
jond01
jond01 reviewed May 19, 2024
View reviewed changes
Copy link
Member

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

tests/model_monitoring/test_stores/test_v3io.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
@gtopper gtopper requested a review from jond01 May 19, 2024 09:35
jond01
jond01 requested changes May 19, 2024
View reviewed changes
Copy link
Member

@jond01 jond01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the FQN comment in the /metrics-values endpoint.

mlrun/common/schemas/model_monitoring/constants.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
@gtopper
Fixes
b1aefa5
@gtopper
Fixes – system test passes with new checks
1900d7b
@gtopper
Merge remote-tracking branch 'mlrun/development' into ML-6349-endpoints
afec485 
# Conflicts:
#	mlrun/model_monitoring/db/v3io_tsdb_reader.py
#	server/api/api/endpoints/model_endpoints.py
#	tests/model_monitoring/test_stores/test_v3io.py
#	tests/system/model_monitoring/test_app.py
@gtopper
Post merge fixes
9e7346e
@gtopper
Fixes
193de16
@gtopper
Minor refactoring
05b9581
@gtopper
Merge remote-tracking branch 'mlrun/development' into ML-6349-endpoints
5e8544b
jond01
jond01 reviewed May 22, 2024
View reviewed changes
mlrun/model_monitoring/db/v3io_tsdb_reader.py Outdated Show resolved Hide resolved
mlrun/common/schemas/model_monitoring/constants.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
@gtopper gtopper requested a review from jond01 May 22, 2024 13:02
jond01
jond01 approved these changes May 22, 2024
View reviewed changes
server/api/api/endpoints/model_endpoints.py Outdated Show resolved Hide resolved
@gtopper
Revert "CR"
c9ff776 
This reverts commit 36fc9e3.
@assaf758 assaf758 merged commit b08f60b into mlrun:development May 22, 2024
11 checks passed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@gtopper @rokatyy
[Model Monitoring] Add invocations metric (mlrun#5581)
0ccae6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jond01 jond01 jond01 approved these changes

@Eyal-Danieli Eyal-Danieli Awaiting requested review from Eyal-Danieli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gtopper @jond01 @assaf758