Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datastore] Fix delete method in filestore and s3 #5582

Merged
merged 6 commits into from
May 20, 2024
Merged

[Datastore] Fix delete method in filestore and s3 #5582

merged 6 commits into from
May 20, 2024

Conversation

tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented May 16, 2024 •
edited
Loading

  1. Fix s3 path issue - in custom rm implementation.
  2. Fix the usage of file:// schema.
  3. Add tests to each fix.

ML-6393

@assaf758 assaf758 merged commit 3f1f138 into mlrun:development May 20, 2024
11 checks passed
gtopper added a commit to gtopper/mlrun that referenced this pull request May 28, 2024
@gtopper
[Datastore] Fix S3Store.rm()
6ff0ebc 
[ML-6587](https://iguazio.atlassian.net/browse/ML-6587)

Following breakage in 1.7.8-rc18, introduced by mlrun#5582.
@gtopper gtopper mentioned this pull request May 28, 2024
Closed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@tomerm-iguazio @rokatyy
[Datastore] Fix delete method in filestore and s3 (mlrun#5582)
65261a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assaf758 assaf758 assaf758 approved these changes

@liranbg liranbg liranbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomerm-iguazio @assaf758 @liranbg