-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications & KFP] Move Workflow Step Analysis to Pipelines-Adapters #5583
[Notifications & KFP] Move Workflow Step Analysis to Pipelines-Adapters #5583
Conversation
quaark
commented
May 16, 2024
•
edited
Loading
edited
- Move all the kfp1.8 specific code to be part of pipelines-adapters so that we can add the functionality to kfp2 in the future.
- Display Skipped steps in pipeline notification as well:
![Screenshot 2024-05-20 at 10 42 42](https://private-user-images.githubusercontent.com/12761913/331984393-a05a94ad-d5e0-4787-aae0-2e0e4a552f94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNzUyNjEsIm5iZiI6MTcxOTM3NDk2MSwicGF0aCI6Ii8xMjc2MTkxMy8zMzE5ODQzOTMtYTA1YTk0YWQtZDVlMC00Nzg3LWFhZTAtMmUwZTRhNTUyZjk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDA0MDkyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5ODJhMWNiMzU4ZDQ2YWQxNGMzNWRlOGExNDZiZjk0ODNiYTY1MzEzNmNkOWJiMzZkZDc3NTRhYjdlNjg2NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ugAv8asMB-3VQNaqqPDbWDrred1JN3UaMymaa-_p43w)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some small comments though
…aark/mlrun into pipeline-step-class-for-notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…aark/mlrun into pipeline-step-class-for-notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👑
…rs (mlrun#5583) * Moved step analysis to mlrun-pipelines * show skipped * CR * CR2 --------- Co-authored-by: quaark <a.melnick@icloud.com>