Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications & KFP] Move Workflow Step Analysis to Pipelines-Adapters #5583

Merged
merged 26 commits into from
May 20, 2024

Conversation

quaark
Copy link
Member

@quaark quaark commented May 16, 2024

  • Move all the kfp1.8 specific code to be part of pipelines-adapters so that we can add the functionality to kfp2 in the future.
  • Display Skipped steps in pipeline notification as well:
Screenshot 2024-05-20 at 10 42 42

@quaark quaark changed the title [Notifications][KFP] Move Workflow Step Analysis to Pipelines-Adapters [Notifications & KFP] Move Workflow Step Analysis to Pipelines-Adapters May 16, 2024
@quaark quaark marked this pull request as ready for review May 20, 2024 07:44
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some small comments though

mlrun/utils/notifications/notification_pusher.py Outdated Show resolved Hide resolved
mlrun/utils/notifications/notification_pusher.py Outdated Show resolved Hide resolved
mlrun/utils/notifications/notification_pusher.py Outdated Show resolved Hide resolved
mlrun/utils/notifications/notification_pusher.py Outdated Show resolved Hide resolved
Copy link
Contributor

@laurybueno laurybueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

quaark added 2 commits May 20, 2024 15:53
…aark/mlrun into pipeline-step-class-for-notifications
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@quaark quaark merged commit 49d0656 into mlrun:development May 20, 2024
11 checks passed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
…rs (mlrun#5583)

* Moved step analysis to mlrun-pipelines

* show skipped

* CR

* CR2

---------

Co-authored-by: quaark <a.melnick@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants