Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frameworks] Bump lightgbm #5588

Merged
merged 1 commit into from
May 22, 2024
Merged

[Frameworks] Bump lightgbm #5588

merged 1 commit into from
May 22, 2024

Conversation

liranbg
Copy link
Member

@liranbg liranbg commented May 17, 2024

Making MLRun better arm64-compatible.

@liranbg liranbg requested a review from guy1992l May 17, 2024 19:37
guy1992l
guy1992l approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@guy1992l guy1992l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to say I'm in favor of removing lightgbm from any req file. It is a user framework and only if the user uses it, we should have a "defense mechanism" that will check that lightgbm is indeed ~=4.3 in code during runtime.

@liranbg
Copy link
Member Author

liranbg commented May 19, 2024

ill add a ticket @guy1992l for that. in the meantime, any objections to bump req to 4.3?

@liranbg liranbg merged commit 7ca8988 into mlrun:development May 22, 2024
11 checks passed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@liranbg @rokatyy
[Frameworks] Bump lightgbm (mlrun#5588)
7b8d7b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy1992l guy1992l guy1992l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liranbg @guy1992l