Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] Add support for summary message #5590

Merged
merged 1 commit into from
May 21, 2024
Merged

[Alerts] Add support for summary message #5590

merged 1 commit into from
May 21, 2024

Conversation

yanburman
Copy link
Contributor

@yanburman yanburman commented May 19, 2024 •
edited
Loading

@yanburman yanburman marked this pull request as ready for review May 19, 2024 13:29
theSaarco
theSaarco requested changes May 19, 2024
View reviewed changes
Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what about unit tests?
Also, there's another location in alert.py where you're using the $project and $entity notation - should be modified as well.

theSaarco
theSaarco reviewed May 19, 2024
View reviewed changes
Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but I thought to add a test to verify that the place-holders are indeed being replaced when formatting events.
You can add a simple unit test that calls format_alert_summary directly for now, but we should have a test that the functionality is working as expected. Of course, this should also be verified with more complex tests later.

@yanburman
[Alerts] Add support for summary message
465103e 
Signed-off-by: Yan Burman <yanburman@users.noreply.github.com>
theSaarco
theSaarco approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sababa

@quaark quaark merged commit e993ee2 into mlrun:development May 21, 2024
11 checks passed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@yanburman @rokatyy
[Alerts] Add support for summary message (mlrun#5590)
a65ba57 
Signed-off-by: Yan Burman <yanburman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaark quaark quaark approved these changes

@theSaarco theSaarco theSaarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yanburman @quaark @theSaarco