[Pipelines] Support watch remote:local engine #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mlrun/projects/pipelines.py
TomerShor
reviewed
May 27, 2024
mlrun/projects/pipelines.py
Outdated
| @@ -742,6 +746,9 @@ class _RemoteRunner(_PipelineRunner): | |||
|
|
|||
| engine = "remote" | |||
|
|
|||
| def __init__(self): | |||
| self.inner_runner: type[_PipelineRunner] = _KFPRunner | |||
There was a problem hiding this comment.
Where is this being used?
the inner engine is passed as an argument to get_run_status, doesn't look like it should be a property
There was a problem hiding this comment.
right its a leftover from solution. removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to watch a remote pipeline with local inner engine.
The pipeline runs a kubejob runner which runs the pipeline without kfp inside the job (local to the job).
After we watch the job we enrich with the run state and error.
https://iguazio.atlassian.net/browse/ML-5334
tested with
test_remote_pipeline_with_local_engine_from_github