[KFP] Fix Pipeline Formatting and Project Deletion not Deleting KFP Experiments #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
May 21, 2024
added 2 commits
May 21, 2024 11:26
rokatyy
pushed a commit
to rokatyy/mlrun
that referenced
this pull request
May 28, 2024
…xperiments (mlrun#5602) * fix pipeline formatting * nicer * nicer * fix for no resource references --------- Co-authored-by: quaark <a.melnick@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6486
The
FlexibleMapperphilosophy was to have a dictionary representation with only the class members being in the representation. This was in order to mask internal kfp data structure implementation and not rely on it.However, this caused 2 problems (problem 2 is the result of problem 1):
to_dictmethods in mlrun, where our usual expectation is thatto_dictis a full serializer that can then be deserialized with afrom_dictmethod.full, we usedto_dictand got a heavily sanitized version of the pipeline. (Therefore the delete project could not infer the experiment id to delete from KFP).After some consideration and consulting with @laurybueno and @liranbg, we decided to align the
FlexibleMapper'sto_dictmethod to function like all otherto_dictmethods in mlrun, but will also contain the class properties which will take precedence and override any internal data if a key conflict exists.In addition, moved the
experiment_idextraction to thePipelineRunclass in 1.8 adapters as that is a kfp 1.8 specific implementation.Lastly, aligned all recent changes in 1.8 adapters to 2.0 adapter stubs.