[Notifications] Redact Secret Params from Notification Data in Webhook Notification #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
April 3, 2024 11:05
rokatyy
pushed a commit
to rokatyy/mlrun
that referenced
this pull request
May 28, 2024
…k Notification (mlrun#5610) redact secret params Co-authored-by: quaark <a.melnick@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6471
Created server side implementation of
NotificationPusherthat inherits the originalNotificationPusherand adds masking the runs' notification configs just before being sent in the notification. This is mainly relevant for webhook notifications which include the entire body of the run and not a pretty display with cherry-picked data.