-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Fix Spammy Pagination Logs on Token Expiry #5612
Merged
quaark
merged 25 commits into
mlrun:development
from
quaark:less-spammy-pagination-logs
May 22, 2024
Merged
[Pagination] Fix Spammy Pagination Logs on Token Expiry #5612
quaark
merged 25 commits into
mlrun:development
from
quaark:less-spammy-pagination-logs
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonmr
approved these changes
May 22, 2024
gtopper
reviewed
May 22, 2024
gtopper
approved these changes
May 22, 2024
liranbg
approved these changes
May 22, 2024
rokatyy
pushed a commit
to rokatyy/mlrun
that referenced
this pull request
May 28, 2024
* Less spammy logs * CR --------- Co-authored-by: quaark <a.melnick@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality of "expected mlrun errors".
When these errors occur and return an error status code via the API, they will not log the whole traceback of the error, and the log line will be debug instead of warning as indeed these errors are expected.
Added a
MLRunPaginationEndOfResultsError
which is one of these expected errors. This way when the pagination token expires we have a nicer log saying it.Before:
After: