[APIGateway] Keep mlrun function names in API gateway object on client side #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
May 26, 2024
| mlrun.common.helpers.parse_versioned_object_uri(func) | ||
| ) | ||
|
|
||
| if parsed_project and function_name: |
There was a problem hiding this comment.
if function_name is not None that it wasn't a URI?
If so - explain this in the comment above (L287)
There was a problem hiding this comment.
@TomerShor I have a comment above
…-6491-keep-mlrun-names # Conflicts: # mlrun/common/constants.py
TomerShor
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - https://iguazio.atlassian.net/browse/ML-6491
There is a confusion between nuclio function names and mlrun function names in MLRun’s api gateway implementation. The problem is that now when functions are passed as MLRun object, mlrun generates a nuclio name and keeps it in
api_gateway.functions(not an MLRun name). It can be a bit confusing for a user, so this is how the problem is solved:We will keep MLRun function URI in
api_gateway.functionand generate nuclio function name just on MLRun api sideWhen sending api gateway request to nuclio api, we also need to populate an annotation which contains MLRun function URI (this functionality will be used in the future for https://iguazio.atlassian.net/browse/ML-6363)
When receive api gateway object from nuclio api, we want to decode a URI from annotation back to mlrun function name on MLRun api side, so when we get it on MLRun client side user won’t even have an idea what nuclio function name is.