Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datastore] Improve error on invalid URL in get_store_resource() #5619

Merged
merged 1 commit into from
May 26, 2024

Conversation

gtopper
Copy link
Collaborator

@gtopper gtopper commented May 23, 2024

Relates to ML-6520.

The new check is added to avoid this error on an invalid URL:

mlrun.errors.MLRunInvalidArgumentError: Field 'model_endpoint.spec.model_uri' should be of type 'ModelArtifact' (got: DataItem with value: ).

Relates to [ML-6520](https://iguazio.atlassian.net/browse/ML-6520).

The new check is added to avoid this error on an invalid URL:
```
mlrun.errors.MLRunInvalidArgumentError: Field 'model_endpoint.spec.model_uri' should be of type 'ModelArtifact' (got: DataItem with value: ).
```
@gtopper gtopper requested a review from Eyal-Danieli May 23, 2024 11:46
Copy link
Member

@Eyal-Danieli Eyal-Danieli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtopper gtopper merged commit 94261fa into mlrun:development May 26, 2024
12 checks passed
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
…lrun#5619)

Relates to [ML-6520](https://iguazio.atlassian.net/browse/ML-6520).

The new check is added to avoid this error on an invalid URL:
```
mlrun.errors.MLRunInvalidArgumentError: Field 'model_endpoint.spec.model_uri' should be of type 'ModelArtifact' (got: DataItem with value: ).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants