Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Store] Fix additional filters CSVSource bug #5639

Merged

Conversation

tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented May 27, 2024

  1. Pass additional_filters parameter to source in spark merger only if required (bugfix).
  2. Added a support for additional_filters in get_offline_features of feature_vector.py.

ML-6544

@tomerm-iguazio tomerm-iguazio changed the title Fix additional filters init bug [FeatureStore] Fix additional filters CsvSource bug May 27, 2024
@gtopper gtopper changed the title [FeatureStore] Fix additional filters CsvSource bug [FeatureStore] Fix additional filters CSVSource bug May 28, 2024
@gtopper gtopper changed the title [FeatureStore] Fix additional filters CSVSource bug [Feature Store] Fix additional filters CSVSource bug May 29, 2024
@assaf758 assaf758 requested a review from alxtkr77 June 2, 2024 11:03
@assaf758 assaf758 requested a review from gtopper June 2, 2024 11:04
@assaf758 assaf758 merged commit 3e8d318 into mlrun:development Jun 2, 2024
11 checks passed
@tomerm-iguazio tomerm-iguazio deleted the fix_additional_filters_init_bug branch June 3, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants