-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Store] Fix additional filters CSVSource
bug
#5639
Merged
assaf758
merged 16 commits into
mlrun:development
from
tomerm-iguazio:fix_additional_filters_init_bug
Jun 2, 2024
Merged
[Feature Store] Fix additional filters CSVSource
bug
#5639
assaf758
merged 16 commits into
mlrun:development
from
tomerm-iguazio:fix_additional_filters_init_bug
Jun 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) add additional_filters to feature_vector.get_offline_features api.
add vector.get_offline_features in test_spark_engine.py.
… into fix_additional_filters_init_bug
CSVSource
bug
CSVSource
bugCSVSource
bug
assaf758
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional_filters
parameter to source in spark merger only if required (bugfix).get_offline_features
of feature_vector.py.ML-6544