-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecations] Deprecate SQLite Migrations #5650
Merged
liranbg
merged 20 commits into
mlrun:development
from
quaark:deprecate-sqlite-migrations-2
Jun 4, 2024
Merged
[Deprecations] Deprecate SQLite Migrations #5650
liranbg
merged 20 commits into
mlrun:development
from
quaark:deprecate-sqlite-migrations-2
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into deprecate-sqlite-migrations
… into deprecate-sqlite-migrations
…un into deprecate-sqlite-migrations-2
liranbg
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-5884
We still support SQLite as a DB, but no longer do we support upgrading the SQLite DB with alembic migrations. Now migrations are only for MySQL:
utf8_bin
toutf8mb3_bin
.utf8_bin
is deprecated in MySQL and now usesutf8mb3_bin
whenutf8_bin
is set. Alembic tries to migrate the db back toutf8_bin
but shouldn't. Now the collation in code matches MySQL collation. TODO: upgrade toutf8mb4_bin
in the future as described in the MySQL warning.