Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecations] Deprecate SQLite Migrations #5650

Merged
merged 20 commits into from
Jun 4, 2024

Conversation

quaark
Copy link
Member

@quaark quaark commented May 29, 2024

https://iguazio.atlassian.net/browse/ML-5884

We still support SQLite as a DB, but no longer do we support upgrading the SQLite DB with alembic migrations. Now migrations are only for MySQL:

  • Removed sqlite migrations and models file
  • API only runs migrations if DB engine is mysql
  • Move migration tests to test against mysql and not sqlite (removed 3 tests that are no longer relevant as those migrations are before the init migration of mysql)
  • Added migration with missing changes from mysql db
  • Update mysql collation from utf8_bin to utf8mb3_bin. utf8_bin is deprecated in MySQL and now uses utf8mb3_bin when utf8_bin is set. Alembic tries to migrate the db back to utf8_bin but shouldn't. Now the collation in code matches MySQL collation. TODO: upgrade to utf8mb4_bin in the future as described in the MySQL warning.
2024-05-28 11:29:05 2024-05-28T08:29:05.147254Z 0 [Warning] [MY-013242] [Server] --character-set-server: 'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous.
2024-05-28 11:29:05 2024-05-28T08:29:05.147580Z 0 [Warning] [MY-013244] [Server] --collation-server: 'utf8mb3_bin' is a collation of the deprecated character set UTF8MB3. Please consider using UTF8MB4 with an appropriate collation instead.

@liranbg liranbg merged commit b318ae7 into mlrun:development Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants