-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Artifacts] Improve list artifacts querying #5655
[Artifacts] Improve list artifacts querying #5655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple of things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👑
Previously, when listing artifacts we did several intensive operations against the DB:
All of the above resulted in a lot of overhead and too many queries.
Now we:
producer_uri
filtering to the same for loop as (2) to not iterate over all artifacts again.*outer join if no specific tag was requested so we return artifacts that are tag-less, and a simpler join when querying on a specific tag as in that case tag-less functions are irrelevant.
https://iguazio.atlassian.net/browse/ML-6642