Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Optimize test integration runtime #5668

Merged
merged 1 commit into from
Jun 2, 2024
Merged

[CI] Optimize test integration runtime #5668

merged 1 commit into from
Jun 2, 2024

Conversation

liranbg
Copy link
Member

@liranbg liranbg commented May 30, 2024

Reducing the time to spin up and down mlrun db for each test case allowing them to be reused each test suite.

TomerShor
TomerShor reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@TomerShor TomerShor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but aren't there tests that run in parallel at all?
If so, we might encounter issues when trying to reset the db

@liranbg
Copy link
Member Author

liranbg commented Jun 2, 2024

Code looks good, but aren't there tests that run in parallel at all? If so, we might encounter issues when trying to reset the db

no parallel for integration.

@liranbg liranbg merged commit 76482a4 into mlrun:development Jun 2, 2024
11 checks passed
@liranbg liranbg deleted the reuse-mlrun-db-integ-tests branch June 2, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liranbg @TomerShor