Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerts] Populate event cache upon api restart #5683

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

yanburman
Copy link
Contributor

We need to handle a case where alert was created and mlrun-api was restarted after that. Need to populate event cache from DB in such case

https://iguazio.atlassian.net/issues/ML-6616

@liranbg liranbg changed the title [Alerts] Populate event cache upon re-start [Alerts] Populate event cache upon api restart Jun 2, 2024
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to ensure mlrun startup critical path is not compromised. its memory is managed correctly by not loading all records without putting a rough limit. and access to db is not naive

server/api/initial_data.py Outdated Show resolved Hide resolved
server/api/db/sqldb/db.py Show resolved Hide resolved
server/api/crud/alerts.py Show resolved Hide resolved
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

server/api/crud/alerts.py Outdated Show resolved Hide resolved
We need to handle a case where alert was created and
mlrun-api was restarted after that. Need to populate
event cache from DB in such case

Signed-off-by: Yan Burman <yanburman@users.noreply.github.com>
@liranbg liranbg merged commit f791264 into mlrun:development Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants