Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Monitoring] Update disable_model_monitoring sdk and api & Added new api and sdk fordelete_model_monitoring_function #5685

Merged
merged 14 commits into from
Jun 5, 2024

Conversation

davesh0812
Copy link
Contributor

https://iguazio.atlassian.net/browse/ML-5857, https://iguazio.atlassian.net/browse/ML-5826.

Note: in order to delete v3io stream we have to wait until the function pod is deleted.

@liranbg liranbg changed the title [Model Monitoring] update disable_model_monitoring sdk and api. [Model Monitoring] update disable_model_monitoring sdk and api Jun 3, 2024
@liranbg liranbg changed the title [Model Monitoring] update disable_model_monitoring sdk and api [Model Monitoring] Update disable_model_monitoring sdk and api Jun 3, 2024
@davesh0812 davesh0812 changed the title [Model Monitoring] Update disable_model_monitoring sdk and api [Model Monitoring] Update disable_model_monitoring sdk and api & Added new api and sdk delete_model_monitoring_function Jun 3, 2024
@davesh0812 davesh0812 changed the title [Model Monitoring] Update disable_model_monitoring sdk and api & Added new api and sdk delete_model_monitoring_function [Model Monitoring] Update disable_model_monitoring sdk and api & Added new api and sdk fordelete_model_monitoring_function Jun 3, 2024
@jond01 jond01 self-requested a review June 3, 2024 14:37
Copy link
Member

@Eyal-Danieli Eyal-Danieli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esh!

few comments, mainly recommendations and desc

mlrun/db/base.py Show resolved Hide resolved
mlrun/db/httpdb.py Show resolved Hide resolved
mlrun/db/httpdb.py Show resolved Hide resolved
mlrun/db/httpdb.py Outdated Show resolved Hide resolved
mlrun/db/httpdb.py Show resolved Hide resolved
mlrun/projects/project.py Outdated Show resolved Hide resolved
server/api/api/endpoints/model_monitoring.py Outdated Show resolved Hide resolved
tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
@assaf758 assaf758 merged commit dff0f03 into mlrun:development Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants