Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureStore] Avoid raising error in dict pop #5695

Merged

Conversation

tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented Jun 3, 2024

source_kwargs does not always contain additional_filters.
Avoid raising an error.

part of ML-6673 solution.

@tomerm-iguazio tomerm-iguazio changed the title [] [FeatureStore] avoid raising error in dict pop Jun 3, 2024
@tomerm-iguazio tomerm-iguazio changed the title [FeatureStore] avoid raising error in dict pop [FeatureStore] שׁvoid raising error in dict pop Jun 3, 2024
@tomerm-iguazio tomerm-iguazio changed the title [FeatureStore] שׁvoid raising error in dict pop [FeatureStore] Avoid raising error in dict pop Jun 3, 2024
@assaf758 assaf758 merged commit d8bf9f4 into mlrun:development Jun 3, 2024
15 of 16 checks passed
@tomerm-iguazio tomerm-iguazio deleted the fix_pop_additional_filters branch June 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants