[Notifications] Improve Remote Workflow Start Notification Functionality #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
approved these changes
Jun 3, 2024
rokatyy
reviewed
Jun 3, 2024
added 2 commits
June 3, 2024 13:09
…n into remote-webhook-notif-running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6644
whenbeingrunningis set in the notification, this notification's parameters will be used for the pipeline start notification. (Otherwise we take the params of the last notification in the list)TODO: discuss if we want to change the behavior to opt in to the start notification by using a notification with
runningand not send it if it doesn't exist.