Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] Add deletion failure details #5698

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[Functions] Add deletion failure details #5698

merged 3 commits into from
Jun 4, 2024

Conversation

rokatyy
Copy link
Member

@rokatyy rokatyy commented Jun 3, 2024 •
edited
Loading

Jira - https://iguazio.atlassian.net/browse/ML-6553

Add deletion failure details when function is being deleted via SDK

@rokatyy rokatyy marked this pull request as ready for review June 3, 2024 09:12
moranbental
moranbental suggested changes Jun 3, 2024
View reviewed changes
mlrun/db/httpdb.py Outdated Show resolved Hide resolved
quaark
quaark reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put parameters in the logger parameters. Not a must if there's a specific reason to put it in the log message itself though

mlrun/db/httpdb.py Outdated Show resolved Hide resolved
quaark
quaark approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

moranbental
moranbental approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@moranbental moranbental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alonmr alonmr merged commit 64867f7 into mlrun:development Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg approved these changes

@quaark quaark quaark approved these changes

@moranbental moranbental moranbental approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rokatyy @liranbg @quaark @moranbental @alonmr