[Alerts] Verify entity and notifications exist before storing alert #5711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanburman
approved these changes
Jun 4, 2024
alonmr
reviewed
Jun 4, 2024
| @@ -74,11 +74,17 @@ def validate_required_fields(self): | |||
| def to_dict(self, fields: list = None, exclude: list = None, strip: bool = False): | |||
| data = super().to_dict(self._dict_fields) | |||
|
|
|||
| if self.entities is None: | |||
There was a problem hiding this comment.
I don't see an issue with the error but the way you use to_dict to parse the entities and notifications is not really the mlrun way. you should use _serialize_field see ModelObj._fields_to_serialize
alonmr
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide more user-friendly error messages in case the user tries to store an alert without providing entity or at least one notification.
resolves:
https://iguazio.atlassian.net/browse/ML-6676