Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KFP] Enforce kfp is imported from pipeline adapters only #5731

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

liranbg
Copy link
Member

@liranbg liranbg commented Jun 6, 2024

Blocking mlrun package from directly importing kfp
This PR is the last step before introducing "nop kfp" kinda adapter which basically makes mlrun package to not relay on any kfp

@liranbg liranbg requested a review from quaark June 18, 2024 05:37
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing shouldn't be removed though

mlrun/projects/pipelines.py Outdated Show resolved Hide resolved
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranbg liranbg merged commit 11bc058 into mlrun:development Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants