[Dask] Change start cluster endpoint to be async #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add endpoint for background task Move background task under project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw several failures recently running our dask example notebook
The image used for the dask cluster is
mlrun/ml-modelswhich is a pretty big image.Before this PR the start cluster endpoint was waiting for the cluster to actually come up, which could take long time since just pulling the image can take several minutes, and in Iguazio system the ingress timeout is 2 minutes.
Added a new resource
BackgroundTaskthat the endpoint will return, then the client query the background tasks endpoint to determine when the task is finishedUnrelated: