-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Projects] Sync SDK class with API methods + structure change #596
Merged
Hedingber
merged 29 commits into
mlrun:development
from
Hedingber:project_structure_change
Dec 17, 2020
Merged
[Projects] Sync SDK class with API methods + structure change #596
Hedingber
merged 29 commits into
mlrun:development
from
Hedingber:project_structure_change
Dec 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structure to enable transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.save()
would cause the project to be saved to a file, there was no useful way to actually back up the projects to the DB. (Note the projects were getting created in the DB when you created a resource of a project (function,run,artifact etc..) but it was only the name without all the project data) - This PR changed that, from now on.save()
would save to the DB (in addition to saving to file) + all of the API methods (httpdb) are accepting and returningMlrunProject
instances, so you can get a project from the db by doing:metadata
,spec
andstatus
like our other resources. Except than different output file format this should be completely transparent to the user, the code "knows" how to load from the old structure file, and there are "proxy attributes" so if your code is doingproject.name
(while it should doproject.metadata.name
) it will work and won't explode (though there is a deprecation plan for these proxy attributes)So a project file looked something like:
will now look something like:
Should be Merged/released together with mlrun/ui#322