[Model Monitoring] Add endpoint registration to v2 serving + config changes #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Michaelliv
commented
Apr 11, 2021
Michaelliv
commented
- Updated model monitoring config to allow a similar functionality to the feature store config, this PR introduces a single template for data store paths instead of individual paths for kv, tsdb and parquets.
- Implemented endpoint "registration" in v2_model_server.
…ndividual paths for all data stores. Updated code and tests to accommodate for said test. Implemented endpoint registration in v2_model_server.
Michaelliv
changed the title
Hedingber
approved these changes
Apr 12, 2021
Hedingber
changed the title
yaronha
reviewed
Apr 12, 2021
yaronha
reviewed
Apr 12, 2021
yaronha
reviewed
Apr 12, 2021
| @@ -103,6 +110,11 @@ def post_init(self, mode="sync"): | |||
| else: | |||
| self._load_and_update_state() | |||
|
|
|||
| if self._model_logger is not None and not isinstance( | |||
| self._model_logger.output_stream, _DummyStream | |||
There was a problem hiding this comment.
better move the condition to the init_endpoint_record func
yaronha
reviewed
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.