[Config] Fix typo in config enrichment from server #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #812 I made the scrape metrics configurable, as part of it, I added logic for the client to read this value from the server, when the server don't have value, it defaults to what the client currently have (
config.scrape_metrics). I had a typo that it default toconfig.kfp_imageinsteadPractically in every 0.6.2 server this will be configured, but the meaning is that running a 0.6.2 client with 0.6.1 server (which don't have it configured) will cause weird failures (trying to set the scrape metrics to an image name)