New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add ingest endpoint to feature store #876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
changed the title
[Feature store/API] Ingest api
[API] Add ingest endpoint to feature store
Apr 24, 2021
Hedingber
suggested changes
Apr 25, 2021
Hedingber
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support feature-store ingest through an MLRun API.
API endpoint:
API is based on an existing feature-set. If the UI needs to ingest a new feature-set, it will need to first create the feature-set (POST/PUT) and then perform the ingest call.
POST /api/projects/{project}/feature-sets/{name}/references/{reference}/ingest
The API server will generate a remote job to perform the ingest operation. The caller will get the details of the run as result, and can use it to track its results and status.
Payload:
name
andkind
, andpath
for the source). Additional parameters may be passed (for example,schedule
for source), and will be passed to theingest
function as part of the data-source and data-target objects.Header parameters:
Those are optional, and are needed just in case v3io mount is required. The UI doesn't need to provide them as they are added automatically in an Iguazio system (and in open-source they are not needed, as mentioned):
Returns:
On success, the API returns a
202 (ACCEPTED)
response, since it triggers an async background process. The body of the response is:This PR covers the functionality and was tested manually. Unit tests and system tests will be added separately.
Implements https://jira.iguazeng.com/browse/ML-368