[API] Fix model monitoring endpoints sync/async separation #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Apr 25, 2021
Comment on lines
34
to
37
| await run_in_threadpool( | ||
| ModelEndpoints.create_or_patch, | ||
| access_key=access_key, | ||
| model_endpoint=model_endpoint, |
There was a problem hiding this comment.
I think this endpoint can be changed to be sync as well
| @@ -47,8 +50,11 @@ async def delete_endpoint_record( | |||
| Clears endpoint record from KV by endpoint_id | |||
| """ | |||
| access_key = get_access_key(request.headers) | |||
| await ModelEndpoints.delete_endpoint_record( | |||
| access_key=access_key, project=project, endpoint_id=endpoint_id | |||
| await run_in_threadpool( | |||
| @@ -79,7 +85,8 @@ async def list_endpoints( | |||
| api/projects/{project}/model-endpoints/?label=mylabel=1,myotherlabel=2 | |||
| """ | |||
| access_key = get_access_key(request.headers) | |||
| endpoints = await ModelEndpoints.list_endpoints( | |||
| endpoints = await run_in_threadpool( | |||
| @@ -105,7 +112,8 @@ async def get_endpoint( | |||
| feature_analysis: bool = Query(default=False), | |||
| ) -> ModelEndpoint: | |||
| access_key = get_access_key(request.headers) | |||
| endpoint = await ModelEndpoints.get_endpoint( | |||
| endpoint = await run_in_threadpool( | |||
Hedingber
changed the title
Hedingber
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…threadpool