[Feature store] Handling multiple targets of same type/name/path #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Apr 25, 2021
mlrun/datastore/targets.py
Outdated
| + targets_by_kind_name | ||
| ) | ||
| overriding_name_target_types = [ | ||
| t[0] for t in no_name_target_types_count.items() if t[1] > 1 |
There was a problem hiding this comment.
Suggested change
| t[0] for t in no_name_target_types_count.items() if t[1] > 1 | |
| target for target, target_count in no_name_target_types_count.items() if target_count > 1 |
mlrun/datastore/targets.py
Outdated
| ] | ||
| + targets_by_kind_name | ||
| ) | ||
| overriding_name_target_types = [ |
There was a problem hiding this comment.
Suggested change
| overriding_name_target_types = [ | |
| target_types_requiring_name = [ |
| overriding_path_target_types | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
You're only verifying here the targets that gets the default name
What about verifying that the case where you received several targets, that has names, but more than one target has the same name ?
urihoenig
changed the title
urihoenig
changed the title
urihoenig
changed the title
Hedingber
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iguazeng.com/browse/ML-387