[Feature Store] Making features/entities optional in feature-set spec #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in
FeatureSetSpec
had features and entities as mandatory lists. This means that if a user doesfeature_set.save()
on an object without them, it will cause failures. This is not the expected behavior.As a side effect, once they became optional, had to change the way
feature_set.dict()
behaves and addexclude_none=True
, because otherwise the dictionary created would have (for example){"entities": None}
, and various get calls such asentities = feature_set_spec.pop("entities", [])
would returnNone
rather than the expected[]
since the default value is only used when the key does not exist in the dictionary, not when it is None. Usingexclude_none
fixes this behaviour.