[Runtimes] Fix skipped deployment to set the right image #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
.deploy()
when nothing specified doesn't really require deploy since the default base image ismlrun/mlrun
so although by defaultwith_mlrun
isTrue
there's no need to install mlrun on it, since it's already installed.There was a bug that caused the wrong image to be set on the function's spec + deploy was returning False as if it was failed - Fixed it
Also changed the default base image to be configurable
Fixes #900