Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jupyter image] Fix installations to be done by notebook user #937

Merged
merged 1 commit into from
May 17, 2021

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented May 17, 2021

We noticed that when we installing certain packages (like nuclio-jupyter) that are already installed pip doesn't remove the old installation
Also when trying to manually uninstall them we got permission errors
The permission error happened because we're running the pip install in the docker file under the root user, and not the notebook user - fixed that
After some more playing with it I found out that pip doesn't automatically uninstall the package only on the first time and only when we're installing from git (i.e. just doing pip intsall to some older version does uninstall the old (newer) version, doing another installation after the first one from git does uninstall the old installation) not sure what's the cause for this after some help from @AlonMaor14 we found the reason - pip does not uninstall the old package is that when it pulls the code from git it checks its version - the version is the same as I have locally, so pip decides that no installation of the new code is actually needed and just use the old code 馃う , you can see it by adding -vvv to the pip install
When I bumped the package version in my branch, everything worked like charm..
Another way to workaround it is adding -U to pip install

@Hedingber Hedingber merged commit b9c73ff into mlrun:development May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant