Impl [Projects] New jobs monitoring #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavdryk
suggested changes
Feb 9, 2024
mavdryk
suggested changes
Mar 4, 2024
| return ( | ||
| <Select | ||
| density='dense' | ||
| className={filter.type === PERIOD_FILTER ? 'period-filter' : ''} |
There was a problem hiding this comment.
Looks like we don't use PERIOD_FILTER anymore. You can delete any logic connected to that filter
There was a problem hiding this comment.
@mavdryk Period has been removed. Added missing filter PROJECT_FILTER to utils since we use it here
filter.type === PROJECT_FILTER
There was a problem hiding this comment.
@ilan7empest Don't get it. If Period filter was removed why we still have condition for the PERIOD_FILTER?
There was a problem hiding this comment.
@mavdryk we don't. It is outdated. Check files changes tab
src/components/ProjectsPage/ProjectsMonitoring/ProjectsMonitoring.js
Outdated
Show resolved
Hide resolved
mavdryk
suggested changes
Mar 15, 2024
src/components/ProjectsPage/ProjectsMonitoring/ProjectsMonitoring.js
Outdated
Show resolved
Hide resolved
src/components/ProjectsPage/ProjectsMonitoring/ProjectsMonitoring.js
Outdated
Show resolved
Hide resolved
src/components/ProjectsPage/ProjectsMonitoring/ProjectsMonitoring.js
Outdated
Show resolved
Hide resolved
mavdryk
suggested changes
Mar 18, 2024
src/elements/ProjectsMonitoringCounters/ScheduledJobsCounters.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: ML-5469