Visualize valid pieces #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsdpk
requested changes
Jan 9, 2021
There was a problem hiding this comment.
Overall, the implementation works properly as it solves the issue. I've highlighted some suggestions for you to improve the code. @aungmcs @aungpaing98
| if self.grid[right_grid_row][right_grid_col] == 0: | ||
| self.valid_pieces.append((row,col)) | ||
| continue | ||
| print(self.valid_pieces) |
There was a problem hiding this comment.
It would be nice to remove this printing statement.
| self.valid_pieces.append((row,col)) | ||
| continue | ||
| print(self.valid_pieces) | ||
| return (len(self.valid_pieces)>0) |
There was a problem hiding this comment.
You can remove the open and close brackets in line 83 return (len(self.valid_pieces)>0)
| @@ -13,10 +13,15 @@ def __init__(self, screen): | |||
| 0 - Selection Mode | |||
| 1 - Active Mode | |||
| ''' | |||
| self.mode = 0 | |||
| self.mode = 9 | |||
There was a problem hiding this comment.
We can make this mode 9 as initial mode 0, and change other modes accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mlsdpk @aungpaing98 @aungmcs please make suggestions and comments for #7