Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak transcript binding of proposals by reference #640

Closed
bifurcation opened this issue May 4, 2022 · 1 comment · Fixed by #688
Closed

Weak transcript binding of proposals by reference #640

bifurcation opened this issue May 4, 2022 · 1 comment · Fixed by #688
Assignees

Comments

@bifurcation
Copy link
Collaborator

In #510 we changed from using full-size hash references to using truncated hashes. This is fine for cases where the reference is only acting as a reference, so unambiguous identification is the only concern.

For proposal references, however, the hash-based reference is also the way that the proposal is incorporated into the transcript. In this case, we end up with a looser binding with truncated hashes, since a malicious transcript need only match a subset of the bits of the hash.

This doesn’t seem like a huge issue in practice, since if the hash function is broken enough to allow 128-bit collisions, we likely have deeper problems. But it might mean that transcript integrity fails before other aspects of the protocol.

To fix this, we could either restore all hash-based identifiers to full size (basically, revert #510), or we could revert just the proposal references. The former would be more uniform; the latter would be more parsimonious. I’m pretty ambivalent between the two.

@bifurcation
Copy link
Collaborator Author

Virtual interim 2022-05-19:

  • Support for doing something here, given 64-bit birthday bound on collisions given 128 bit identifiers
  • Support for full-width everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants