Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smaller, fixed-size hash-based identifiers #510

Merged
merged 1 commit into from Dec 1, 2021
Merged

Use smaller, fixed-size hash-based identifiers #510

merged 1 commit into from Dec 1, 2021

Conversation

bifurcation
Copy link
Collaborator

@bifurcation bifurcation commented Nov 16, 2021 •
edited

Fixes #506
Fixes #504

@bifurcation bifurcation mentioned this pull request Nov 16, 2021
Closed
franziskuskiefer
franziskuskiefer reviewed Nov 17, 2021
View reviewed changes
draft-ietf-mls-protocol.md

For a KeyPackageRef, the `value` input is the encoded KeyPackage, and the
ciphersuite specified in the KeyPackage determines the KDF used. For a
ProposalRef, the `value` input is the MLSPlaintext carrying the proposal, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the Commit section then use ProposalRef rathen than opaque hash<0..255> for the reference?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done via the changes to ProposalOrRef further down.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah missed that, never mind 🤦🏻

@franziskuskiefer
Copy link
Contributor

Fixes #504

@franziskuskiefer franziskuskiefer mentioned this pull request Nov 25, 2021
Closed
@bifurcation bifurcation merged commit f9de42c into main Dec 1, 2021
@bifurcation bifurcation mentioned this pull request May 4, 2022
Closed
rohan-wire pushed a commit to rohan-wire/mls-protocol that referenced this pull request Jun 3, 2022
@bifurcation @rohan-wire
Use smaller, fixed-size hash-based identifiers (mlswg#510)
932b486 
Co-authored-by: Richard L. Barnes <richbarn@cisco.com>
TWal added a commit to Inria-Prosecco/mls-star that referenced this pull request Jun 13, 2022
@TWal
Implement mlswg/mls-protocol#510 (KeyPackageRef)
065a6b5
@raphaelrobert raphaelrobert mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@raphaelrobert raphaelrobert raphaelrobert approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use smaller, fixed-size hash-based identifiers KeyPackage ID vs KeyPackage Identifier
3 participants
@bifurcation @franziskuskiefer @raphaelrobert