-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unambiguous signatures #526
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
420fa4c
Disambiguate signatures
TWal 666e267
Merge branch 'mlswg:main' into twal_signature
TWal 4c0c8bf
Move the group context at the end of MLSPlaintextTBS
TWal 2d10ef4
Merge branch 'main' of github.com:mlswg/mls-protocol into twal_signature
TWal 8c2ba5a
Take Richard comment into account
TWal b92d079
Remove useless newline
TWal 55ad811
Change mls10 to MLS 1.0
TWal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the aesthetics here. Maybe we could solve this a little more elegantly by having a
context
input toSignWithLabel
/VerifyWithLabel
?Alternatively: Do we even need this field any more? This field was added before
membership_tag
, and now themembership_tag
already (a) demonstrates knowledge of the GroupContext and (b) prevents a non-member from synthesizing a valid MLSPlaintext.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I not sure the alternative is a good idea for several reasons, for example the
membership_tag
is present only inMLSPlaintext
and not inMLSCiphertext
, also I'm not confident in removing things from the signature without a solid proof that it is not necessary (for example, signing the tree hash seems like a reasonable thing to do?).I feel like adding a
context
input is a bit weird. What do you think about this third option: adding anoption<GroupContext> group_context;
and say something like "group_context MUST contain a value if sender_type = ..." below? This pattern already exists forconfirmation_tag
for example.