Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove new_member Add proposals. #659

Merged
merged 1 commit into from May 20, 2022
Merged

Remove new_member Add proposals. #659

merged 1 commit into from May 20, 2022

Conversation

Bren2010
Copy link
Collaborator

@Bren2010 Bren2010 commented May 12, 2022

Sending an Add proposal from outside the group is how we let people do "external add" functionality without needing to publish the group state. But you can't talk right away like you can with an external Commit. In that case, applications seem more inclined to build this functionality themselves so let's just remove it from the spec.

@Bren2010 Bren2010 changed the title Don't require new_member sender type to sign GroupContext. Remove new_member Add proposals. May 14, 2022
Copy link
Collaborator

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting this together!

draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
@bifurcation
Copy link
Collaborator

Virtual interim 2022-05-19:

  • External sender change is unrelated
    • @kkohbrok notes that using only SignaturePublicKey loses auth info
    • @Bren2010 to revert this part of the PR
  • Clear to merge once conflicts are cleared and above is reverted

@seanturner
Copy link
Contributor

Once SignaturePublicKey is backed out and merge conflicts fixed - merge.

@bifurcation bifurcation merged commit 4efa333 into main May 20, 2022
TWal added a commit to Inria-Prosecco/mls-star that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants