Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More wording improvements, updating sections that got out of date. #662

Merged
merged 3 commits into from May 20, 2022

Conversation

Bren2010
Copy link
Collaborator

No description provided.

draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
UpdatePath, with a new LeafNode and set of parent nodes for the sender's
filtered direct path. For each intermediate node, the UpdatePath contains a new
public key and encrypted path secret. The nodes are ordered such that each node
is the ancestor of its predecessor.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is the ancestor of its predecessor.
is the next non-blank ancestor of its predecessor in the filtered direct path.

Copy link
Collaborator Author

@Bren2010 Bren2010 May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, the filtered direct path doesn't have blank nodes. Or at least, this way of saying it is not making sense to me right now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how it's confusing to say both. How about either "next non-blank ancestor" or "next ancestor in the filtered direct path"?

Alternatively, the filtered direct path already has an order defined:

The direct path of a root is the empty list, and of any other node is the concatenation of that node's parent along with the parent's direct path.

The filtered direct path of a node is obtained from the node's direct path by removing all nodes ... [note this doesn't change the order]

So we could just say that the nodes in the UpdatePath correspond to the nodes in the filtered direct path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants