Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external senders extension. #682

Merged
merged 1 commit into from May 26, 2022
Merged

Update external senders extension. #682

merged 1 commit into from May 26, 2022

Conversation

Bren2010
Copy link
Collaborator

Closes #681

bifurcation
bifurcation approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bren2010 I like that this captures both the signature and authentication aspects.

@kkohbrok wdyt?

tomleavy
tomleavy reviewed May 21, 2022
View reviewed changes
draft-ietf-mls-protocol.md
Comment on lines +3544 to +3545
SignaturePublicKey signature_key;
Credential credential;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the combo of SignaturePublicKey and Credential just be independently defined as a struct like Identity, and then used in LeafNode as well as in the extension?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd call it "identity", but I think this is a good idea.

kkohbrok
kkohbrok approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@kkohbrok kkohbrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @tomleavy's idea might be a good additional improvement.

draft-ietf-mls-protocol.md
Comment on lines +3544 to +3545
SignaturePublicKey signature_key;
Credential credential;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd call it "identity", but I think this is a good idea.

@bifurcation bifurcation merged commit 60b7fd2 into main May 26, 2022
@raphaelrobert raphaelrobert mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleavy tomleavy tomleavy left review comments

@bifurcation bifurcation bifurcation approved these changes

@kkohbrok kkohbrok kkohbrok approved these changes

@rohan-wire rohan-wire rohan-wire approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External Senders Extension is incomplete
5 participants
@Bren2010 @bifurcation @tomleavy @kkohbrok @rohan-wire