Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify some parts of Application Messages section. #699

Merged
merged 4 commits into from Jun 2, 2022
Merged

Clarify some parts of Application Messages section. #699

merged 4 commits into from Jun 2, 2022

Conversation

Bren2010
Copy link
Collaborator

Closes #679

bifurcation
bifurcation approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of friendly amendments, otherwise lgtm.

I am going to hold this as slightly more than editorial, given the number of MUSTs that are affected. But I would note for others that the MUSTs that are removed here are all redundant with requirements above.

draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
@Bren2010 @bifurcation
Apply suggestions from code review
e421202 
Co-authored-by: Richard Barnes <rlb@ipv.sx>
Bren2010
Bren2010 commented May 25, 2022
View reviewed changes
draft-ietf-mls-protocol.md Outdated Show resolved Hide resolved
raphaelrobert
raphaelrobert approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@raphaelrobert raphaelrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Just one nit, but looks good otherwise.

@bifurcation
Copy link
Collaborator

Interim 2022-05-26:

  • Intended to be mostly editorial
  • Leaving open for now
  • Clear to merge in between meetings if folks are comfortable

@bifurcation
Copy link
Collaborator

Interim 2022-06-02:

  • Still clear from last week

@bifurcation bifurcation merged commit 33ff38a into main Jun 2, 2022
@raphaelrobert raphaelrobert mentioned this pull request Aug 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bifurcation bifurcation bifurcation approved these changes

@raphaelrobert raphaelrobert raphaelrobert approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content encryption: Clarify generation sequence
3 participants
@Bren2010 @bifurcation @raphaelrobert