Add new new_proposal_member SenderType #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bifurcation
reviewed
Jun 2, 2022
draft-ietf-mls-protocol.md
Outdated
Comment on lines
1436
to
1437
| new_commit_member(3), | ||
| new_proposal_member(4), |
There was a problem hiding this comment.
Nit: I would flip these around, new_member_commit and new_member_proposal.
draft-ietf-mls-protocol.md
Outdated
Comment on lines
1450
to
1451
| case new_proposal_member: | ||
| KeyPackageID proposed_member; |
There was a problem hiding this comment.
This can just be struct{}, since because the KeyPackage you apply is the one in the Add proposal.
draft-ietf-mls-protocol.md
Outdated
Comment on lines
1566
to
1568
| case new_proposal_member: | ||
| // The KeyPackage included in embedded Add proposal | ||
| KeyPackage key_package; |
There was a problem hiding this comment.
This doesn't seem all that useful, since the KeyPackage is already being signed via the Add proposal. I would just make this struct{}.
|
Interim 2022-06-02:
|
|
Closes #693 |
bifurcation
approved these changes
Jun 2, 2022
…er to new_member_commit and specify proposal type must be an Add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new new_proposal_member SenderType and rename new_member to new_commit_member.
This restores the External Proposal Add functionality which was present in the protocol for some years but clarifies how the authorization and signing takes place in this case.