Fix resolution example #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mulmarta |
mulmarta
reviewed
Jun 3, 2022
mulmarta
reviewed
Jun 3, 2022
|
Good catch! It's kind of subtle in this case. |
Co-authored-by: mulmarta <103590845+mulmarta@users.noreply.github.com>
|
@mulmarta - I think I have this patched up, would appreciate a quick re-review. |
rohan-wire
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current resolution example tree can't be created by the protocol. If C were not blank, then D would not populate Z in its filtered direct path. (Note that this implies that there are never unmerged leaves at the first level of the tree.) This PR expands the example tree so that it can have unmerged leaves while still having a blank top node. This makes the example a little more complicated (you have to follow the recursion down two levels), but it doesn't seem too bad.