Change MLS-Exporter label from "exporter" to "exported" #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bifurcation
approved these changes
Feb 27, 2023
duesee
reviewed
Mar 1, 2023
There was a problem hiding this comment.
I think this should be adapted, too: https://github.com/mlswg/mls-protocol/pull/864/files#diff-7c369b85b26a746a7e70cd2884037896defe03b3098bec976f79c994d22a604aR2937 Nevermind :-)
|
@duesee, no the point is for the two labels to be different :) |
|
Argh... confused myself, sorry :-) |
TWal
added a commit
to Inria-Prosecco/mls-star
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "exporter" label is used two times : to derive
exporter_secret, and inMLS-Exporter.I'm not sure it's really problematic, but using different labels doesn't cost much, hence this PR.