Reduce collisions in the mlt_properties hash function.

mltframework · Jan 26, 2014 · 1aa26da · 1aa26da
1 parent ebbb877
commit 1aa26da
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/framework/mlt_properties.c b/src/framework/mlt_properties.c
@@ -328,11 +328,10 @@ int mlt_properties_preset( mlt_properties self, const char *name )
 
 static inline int generate_hash( const char *name )
 {
-	int hash = 0;
-	int i = 1;
+	unsigned int hash = 5381;
 	while ( *name )
-		hash = ( hash + ( i ++ * ( *name ++ & 31 ) ) ) % 199;
-	return hash;
+		hash = hash * 33 + (unsigned int) ( *name ++ );
+	return hash % 199;
 }
 
 /** Copy a serializable property to a properties list that is mirroring this one.