Updating mlt-xml.dtd

[camillem]

Hi,
First, thanks for this most useful piece of software that is MLT!

The dtd file seems a little bit outdated compared to the rest of the code, and it doesn't allow to validate mlt files that I think are conformant: I made simple test with Shotcut and Kdenlive and get the same kind of errors with both applications.
Most problems are missing child elements and attributes.
Would that be relevant that I submit a PR with changes to adapt the dtd to the output of Shotcut?
One trickier point is the ID "main bin" in the file, as in xml, ID can't contain spaces, AFAICT.
Do you think that this could be changed without breaking too many things?
Thanks,
Camille

[ddennedy]

Would that be relevant that I submit a PR with changes to adapt the dtd to the output of Shotcut?

Yes, but it should not contain any "shotcut:" attributes.

Do you think that this could be changed without breaking too many things?

Yes, I would make Shotcut start output as "main_bin" and then make whatever code is looking for "main bin" look for either (backwards compatibility).

[camillem]

Thanks for the fastest answer !

[ddennedy]

I have the Shotcut change staged now for testing, but I am busy making new release. I will get to it soon.

[camillem]

Thanks very much.
I have a few (like 2) additional changes but I would like to test the whole thing more thoroughly.
Would you have a pointer to a correct-but-not-so-simple mlt file that I could test the DTD on?

[ddennedy]

test.mlt.txt

[camillem]

Thanks for the file. It produces no error against the current version of the DTD, so I'll submit a new PR.